Skip to content

MINIFICPP-1567 enable linter checks in extensions (part 4)#1112

Closed
martinzink wants to merge 7 commits intoapache:mainfrom
martinzink:MINIFICPP-1567-4
Closed

MINIFICPP-1567 enable linter checks in extensions (part 4)#1112
martinzink wants to merge 7 commits intoapache:mainfrom
martinzink:MINIFICPP-1567-4

Conversation

@martinzink
Copy link
Member

enable rocksdb-repos linter
enable jni linter
enable script linter
enable sftp linter
enable sensor linter

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink marked this pull request as ready for review June 16, 2021 10:53
martinzink and others added 7 commits July 5, 2021 11:26
enable rocksdb-repos linter
enable jni linter
enable script linter
enable sftp linter
enable sensor linter
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
@fgerlits fgerlits closed this in 6dd03a6 Jul 7, 2021
@martinzink martinzink deleted the MINIFICPP-1567-4 branch March 6, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants