Skip to content

MINIFICPP-1586-make linter gives errors when it is run in an unpack…#1113

Closed
aminadinari19 wants to merge 2 commits intoapache:mainfrom
aminadinari19:MINIFICPP_1586_make_linter_gives_errors
Closed

MINIFICPP-1586-make linter gives errors when it is run in an unpack…#1113
aminadinari19 wants to merge 2 commits intoapache:mainfrom
aminadinari19:MINIFICPP_1586_make_linter_gives_errors

Conversation

@aminadinari19
Copy link
Contributor

…ed release tarball

MINIFICPP-1586-keeping script_dir variable

MINIFICPP-1586-Removed '/' from sub-directories

MINIFICPP-1586-make linter gives errors when it is run in an unpacked released tarball

MINIFICPP-1586-new line at the end

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

…ed release tarball

MINIFICPP-1586-keeping script_dir variable

MINIFICPP-1586-Removed '/' from sub-directories

MINIFICPP-1586-`make linter` gives errors when it is run in an unpacked released tarball

MINIFICPP-1586-new line at the end
@aminadinari19 aminadinari19 force-pushed the MINIFICPP_1586_make_linter_gives_errors branch from 0d51073 to c1801ae Compare June 21, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants