MINIFICPP-1573 Make AppendHostInfo platform independent#1116
Closed
martinzink wants to merge 12 commits intoapache:mainfrom
Closed
MINIFICPP-1573 Make AppendHostInfo platform independent#1116martinzink wants to merge 12 commits intoapache:mainfrom
martinzink wants to merge 12 commits intoapache:mainfrom
Conversation
szaszm
reviewed
Jun 24, 2021
martinzink
force-pushed
the
MINIFICPP-1573-PR
branch
2 times, most recently
from
04ce4ed to
d84894d
Compare
fgerlits
reviewed
Jul 22, 2021
extensions/standard-processors/tests/unit/AppendHostInfoTests.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/tests/unit/AppendHostInfoTests.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/tests/unit/AppendHostInfoTests.cpp
Outdated
Show resolved
Hide resolved
fgerlits
approved these changes
Jul 23, 2021
martinzink
force-pushed
the
MINIFICPP-1573-PR
branch
from
19f9c59 to
58e662b
Compare
Co-authored-by: Márton Szász <szaszm01@gmail.com>
szaszm
reviewed
Jul 27, 2021
extensions/standard-processors/tests/unit/AppendHostInfoTests.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/tests/unit/AppendHostInfoTests.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Márton Szász <szaszm01@gmail.com>
Co-authored-by: Márton Szász <szaszm01@gmail.com>
szaszm
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.