MINIFICPP-1596 Refactor docker tests by removing unnecessary clusters#1121
Closed
lordgamez wants to merge 22 commits intoapache:mainfrom
Closed
MINIFICPP-1596 Refactor docker tests by removing unnecessary clusters#1121lordgamez wants to merge 22 commits intoapache:mainfrom
lordgamez wants to merge 22 commits intoapache:mainfrom
Conversation
lordgamez
commented
Jun 30, 2021
8 tasks
bd55bfa to
8082215
Compare
bd24488 to
d9b5b67
Compare
e35d6d0 to
b8a5931
Compare
aminadinari19
approved these changes
Aug 16, 2021
16c29d4 to
7382d99
Compare
7382d99 to
1352f2e
Compare
szaszm
reviewed
Aug 26, 2021
1352f2e to
80442de
Compare
80442de to
163436c
Compare
szaszm
approved these changes
Aug 26, 2021
fgerlits
reviewed
Aug 27, 2021
009cb33 to
78245c9
Compare
fgerlits
approved these changes
Sep 6, 2021
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
357be8b to
c60aef3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed in this PR regarding integration tests:
Clusterconcept in the codebase causing several issuesClusterandContainerconcepts were mixed up in the codebase which made understanding the test code harderSingleNodeDockerClusterclass had way too many responsibilities handling attributes corresponding to specific containersChanges made to resolve the issues:
SingleNodeDockerCluster(single node referring to the intent of running the containers on a single compute node) is now defined as a set ofContainerswith a single Docker network connecting themContainerclass from which all used containers are inherited from defining their own attributes, deployment functions and so on. This moves container specific functionality from theSingleNodeDockerClusterand simplifies the deployment of the clusterJira ticket: https://issues.apache.org/jira/browse/MINIFICPP-1596
This should also fix the following Jira regarding transient failures in cleanup: https://issues.apache.org/jira/browse/MINIFICPP-1516
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.