MINIFICPP-1602 upgrade Catch2 to v2.13.6#1128
Closed
szaszm wants to merge 6 commits intoapache:mainfrom
Closed
Conversation
szaszm
commented
Jul 8, 2021
| REQUIRE(3 == test3.value()); | ||
| REQUIRE(!test4); | ||
| REQUIRE_THROWS_AS(utils::optional<bool>{} | utils::orElse([]{ throw ex{}; }), const ex&); | ||
| REQUIRE_THROWS_AS(utils::optional<bool>{} | utils::orElse([]{ throw ex{}; }), ex); |
Member
Author
There was a problem hiding this comment.
Catch2 REQUIRE_THROWS_AS now adds const& to the type internally.
| @@ -1,4 +1,4 @@ | |||
| filter=-build/namespaces | |||
| filter=-build/namespaces,-whitespace/braces | |||
Member
Author
There was a problem hiding this comment.
There were two false positives in PersistableKeyValueStoreServiceTest.cpp and UnorderedMapKeyValueStoreServiceTest.cpp, "missing whitespace before {" at Catch::clara::Opt construction. The google style guide allows uniform initialization without a space before the brace.
| } | ||
| { | ||
| SCOPED_INFO("ConsumeKafka timed out when waiting to receive the message published to the kafka broker."); | ||
| INFO("ConsumeKafka timed out when waiting to receive the message published to the kafka broker."); |
Member
Author
There was a problem hiding this comment.
INFO in Catch2 is practically the same as SCOPED_INFO in Catch 1.x
fgerlits
reviewed
Jul 9, 2021
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
Outdated
Show resolved
Hide resolved
libminifi/test/keyvalue-tests/PersistableKeyValueStoreServiceTest.cpp
Outdated
Show resolved
Hide resolved
fgerlits
reviewed
Jul 9, 2021
fgerlits
approved these changes
Jul 9, 2021
It called PdhAddEnglishCounterA with an uninitialized handle. MSDN documents that the handle must be one returned by PdhOpenQuery function. The test was violating this precondition, and I believe we don't need to test undefined behavior.
lordgamez
approved these changes
Jul 15, 2021
martinzink
approved these changes
Jul 16, 2021
arpadboda
approved these changes
Jul 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.