Skip to content

MINIFICPP-1627 Do not build OpenCV in the Windows CI job#1160

Closed
fgerlits wants to merge 1 commit intoapache:mainfrom
fgerlits:MINIFICPP-1627_disable-OpenCV-in-Windows-CI-job
Closed

MINIFICPP-1627 Do not build OpenCV in the Windows CI job#1160
fgerlits wants to merge 1 commit intoapache:mainfrom
fgerlits:MINIFICPP-1627_disable-OpenCV-in-Windows-CI-job

Conversation

@fgerlits
Copy link
Contributor

@fgerlits fgerlits commented Aug 11, 2021

As @adamdebreceni measured, out of the ~ 2 hour duration of the Windows CI job, ~ 30 minutes are spent compiling the OpenCV dependency. Since this extension is not vital, and it may not be in good shape as there are no tests for it, we don't want to spend so much time every time a change is pushed.

Also: increase the timeout from 2 to 3 hours.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

... and increase the timeout to 3 hours.
@adamdebreceni
Copy link
Contributor

yes, this is an unfortunate workaround, and hopefully we will be able to reenable it following some project-wide compile-time optimizations

@fgerlits fgerlits deleted the MINIFICPP-1627_disable-OpenCV-in-Windows-CI-job branch September 10, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants