Skip to content

MINIFICPP-1643 Add Managed Identity support for Azure processors#1178

Closed
lordgamez wants to merge 12 commits intoapache:mainfrom
lordgamez:MINIFICPP-1643
Closed

MINIFICPP-1643 Add Managed Identity support for Azure processors#1178
lordgamez wants to merge 12 commits intoapache:mainfrom
lordgamez:MINIFICPP-1643

Conversation

@lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Sep 22, 2021

  • Adding Use Managed Identity Credentials to AzureStorageCredentialsService and PutAzureBlobStorage properties to support managed identities
  • AzureBlobStorage can now support empty Blob property by using the filename attribute as a default
  • Azure processors and AzureStorageCredentialsService now use the following credential priority list if they are set: Managed Identity, Connection String property, any other credential properties
  • PutAzureBlobStorage prioritizes credentials set in the AzureStorageCredentialsService over the ones set in processor properties

https://issues.apache.org/jira/browse/MINIFICPP-1643


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copy link
Member

@martinzink martinzink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me only a few questions regarding the mutex usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants