MINIFICPP-1643 Add Managed Identity support for Azure processors#1178
Closed
lordgamez wants to merge 12 commits intoapache:mainfrom
Closed
MINIFICPP-1643 Add Managed Identity support for Azure processors#1178lordgamez wants to merge 12 commits intoapache:mainfrom
lordgamez wants to merge 12 commits intoapache:mainfrom
Conversation
fgerlits
reviewed
Sep 29, 2021
fgerlits
reviewed
Sep 29, 2021
martinzink
reviewed
Sep 30, 2021
Member
martinzink
left a comment
There was a problem hiding this comment.
Looks good to me only a few questions regarding the mutex usage.
martinzink
approved these changes
Sep 30, 2021
fgerlits
approved these changes
Oct 1, 2021
szaszm
reviewed
Oct 1, 2021
szaszm
reviewed
Oct 3, 2021
szaszm
approved these changes
Oct 4, 2021
1ff3b23 to
715c2cb
Compare
adamdebreceni
approved these changes
Oct 6, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Managed Identity CredentialstoAzureStorageCredentialsServiceandPutAzureBlobStorageproperties to support managed identitiesAzureBlobStoragecan now support emptyBlobproperty by using the filename attribute as a defaultAzureStorageCredentialsServicenow use the following credential priority list if they are set: Managed Identity, Connection String property, any other credential propertiesPutAzureBlobStorageprioritizes credentials set in theAzureStorageCredentialsServiceover the ones set in processor propertieshttps://issues.apache.org/jira/browse/MINIFICPP-1643
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.