MINIFI-311 Move to alpine base for docker image.#118
MINIFI-311 Move to alpine base for docker image.#118ai-christianson wants to merge 1 commit intoapache:masterfrom
Conversation
ai-christianson
force-pushed
the
MINIFI-311
branch
from
95e58d0 to
f486b00
Compare
|
reviewing |
apiri
left a comment
apiri
left a comment
There was a problem hiding this comment.
Hey @achristianson,
This is awesome and a very welcomed improvement. Functionally the build is all good and works like a charm. L&N considerations seem fine. I would like to request that we strip out those areas I commented on. In general, we've had some issues with included resources that we weren't using sometimes having uncertain origins. Could you please adjust those and then I think we should be good to go.
| @@ -0,0 +1,90 @@ | |||
| # Adapted from various sources, including: | |||
There was a problem hiding this comment.
We should remove this from the source inclusion. Anything beyond the actual source should get stripped out to minimize LICENSE/NOTICE concerns.
| @@ -0,0 +1,84 @@ | |||
| // | |||
There was a problem hiding this comment.
Should remove the entirety of the bench subdirectory.
| @@ -0,0 +1,49 @@ | |||
| # *************************************************************************/ | |||
There was a problem hiding this comment.
Should remove the entirety of the example directory
| @@ -0,0 +1,19 @@ | |||
| # | |||
There was a problem hiding this comment.
Should remove the tests subdirectory and skip this part of the build for the lib
phrocker
left a comment
phrocker
left a comment
There was a problem hiding this comment.
Overall looks good. I agree with Aldrin's comments about the bench and test dirs.
|
Thanks for the feedback. I will make the required changes and update the PR. |
MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot
ai-christianson
force-pushed
the
MINIFI-311
branch
from
f486b00 to
7c5199a
Compare
|
@apiri removed those dirs & rebased. Should be good to go now. |
|
reviewing changes |
|
hey @achristianson, everything looks good here. will get this merged in. thanks for your adjustments! |
MINIFI-311 ported dockerfile to alpine MINIFI-311 allow warnings on Linux for compatibility with Alpine MINIFI-311 fixed spdlog path in BuildTests cmake file MINIFI-349 moved to multi-stage docker build MINIFI-311 removed unneeded dirs from spdlog snapshot MINIFI-312 Handle spdlog compilation failures in Alpine Linux This closes apache#118. Signed-off-by: Aldrin Piri <aldrin@apache.org>
3 participants
This change takes the 1.5G ubuntu minifi image and reduces it to a 39MB image by using a multi-stage alpine build.
MINIFI-311 ported dockerfile to alpine
MINIFI-311 allow warnings on Linux for compatibility with Alpine
MINIFI-311 fixed spdlog path in BuildTests cmake file
MINIFI-349 moved to multi-stage docker build