MINIFICPP-1692 - TLSSocket hangs when no more data is available#1218
Closed
adamdebreceni wants to merge 8 commits intoapache:mainfrom
Closed
MINIFICPP-1692 - TLSSocket hangs when no more data is available#1218adamdebreceni wants to merge 8 commits intoapache:mainfrom
adamdebreceni wants to merge 8 commits intoapache:mainfrom
Conversation
lordgamez
approved these changes
Nov 29, 2021
adam-markovics
approved these changes
Nov 29, 2021
szaszm
reviewed
Nov 29, 2021
adamdebreceni
changed the title
szaszm
approved these changes
Nov 30, 2021
martinzink
approved these changes
Nov 30, 2021
Contributor
Author
|
I am trying to whip up some tests for this fix |
adamdebreceni
commented
Nov 30, 2021
| LogTestController::getInstance().setTrace<minifi::io::TLSServerSocket>(); | ||
| LogTestController::getInstance().setTrace<minifi::io::TLSContext>(); | ||
|
|
||
| auto server = std::make_unique<SimpleSSLTestServer>(TLSv1_2_server_method(), 0, key_dir); |
Contributor
Author
There was a problem hiding this comment.
I tried to use the TSLServerSocket but couldn't trigger the observed behavior to verify the fix, so I factored out the SimpleSSLTestServer and used that one instead, now the test should fail when the fix is reverted but pass otherwise
martinzink
approved these changes
Nov 30, 2021
Member
martinzink
left a comment
martinzink
left a comment
There was a problem hiding this comment.
LGTM, kudos for the test 👍
szaszm
reviewed
Dec 1, 2021
szaszm
approved these changes
Dec 1, 2021
szaszm
requested changes
Dec 1, 2021
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
Sorry for going back on my vote, but I found this issue while doing my pre-merge tests.
Member
|
Forgot to repost a +1, but the change resolved the test issue, so I merged the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.