MINIFICPP-1669 Use std::byte for buffers#1249
Closed
szaszm wants to merge 10 commits intoapache:mainfrom
Closed
Conversation
szaszm
force-pushed
the
stream_stdbyte
branch
4 times, most recently
from
90a019a to
ce20f79
Compare
lordgamez
approved these changes
Feb 1, 2022
martinzink
approved these changes
Feb 2, 2022
fgerlits
reviewed
Feb 2, 2022
where array iterators are not raw pointers
before the PR, it used to do uninitialized reads that happened to do the right thing. In the PR, that memory became zero-initialized, so it no longer worked. This commit properly shares the buffer, so it works with no UB.
szaszm
force-pushed
the
stream_stdbyte
branch
from
bfa3470 to
4627a61
Compare
fgerlits
approved these changes
Feb 7, 2022
Member
|
I was just checking the c++20 features and we should be able to use std::span, any reason you are using gsl::span instead of std::span? |
Member
Author
|
I want to make the move in a separate PR. |
szaszm
added a commit
to lordgamez/nifi-minifi-cpp
that referenced
this pull request
Feb 17, 2022
…td::byte for buffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial goal was streams only, but it's impossible to change only one part of the code to use std::byte for byte representation.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.