MINIFICPP-1322 PublishKafka queue size and batch size properties should be in sync#1304
Closed
lordgamez wants to merge 2 commits intoapache:mainfrom
Closed
MINIFICPP-1322 PublishKafka queue size and batch size properties should be in sync#1304lordgamez wants to merge 2 commits intoapache:mainfrom
lordgamez wants to merge 2 commits intoapache:mainfrom
Conversation
lordgamez
force-pushed
the
MINIFICPP-1322
branch
2 times, most recently
from
2488602 to
8169893
Compare
lordgamez
force-pushed
the
MINIFICPP-1322
branch
from
8169893 to
f006b4a
Compare
szaszm
reviewed
Apr 14, 2022
martinzink
reviewed
Apr 19, 2022
Member
martinzink
left a comment
martinzink
left a comment
There was a problem hiding this comment.
I know this is not new, but since we are touching it anyways, would you mind moving the tests from libminifi/test/kafka-tests to extensions/librdkafka/tests/ ?
Contributor
Author
Good point, moved it in b5c543d |
martinzink
approved these changes
Apr 19, 2022
szaszm
approved these changes
Apr 19, 2022
| uint32_t int_val; | ||
| if (context->getProperty(QueueBufferMaxMessage.getName(), int_val)) { | ||
| if (int_val < batch_size_) { | ||
| throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Invalid configuration: Batch Size cannot be larger than Queue Max Message"); |
Contributor
There was a problem hiding this comment.
were we able to trigger the expected problematic behavior?
Contributor
Author
There was a problem hiding this comment.
Yes the misconfiguration issue actually came from a user, that's why this ticket was raised to make it more clear if this case happens.
fgerlits
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-1322
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.