MINIFICPP-1832 Integrate first batch of clang-tidy checks in CI#1330
Closed
lordgamez wants to merge 7 commits intoapache:mainfrom
Closed
MINIFICPP-1832 Integrate first batch of clang-tidy checks in CI#1330lordgamez wants to merge 7 commits intoapache:mainfrom
lordgamez wants to merge 7 commits intoapache:mainfrom
Conversation
lordgamez
force-pushed
the
MINIFICPP-1832
branch
9 times, most recently
from
7c5bde7 to
0984455
Compare
szaszm
reviewed
May 12, 2022
thirdparty/rapidjson-48fbd8cd202ca54031fe799db2ad44ffa8e77c13/include/rapidjson/document.h
Show resolved
Hide resolved
extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
Outdated
Show resolved
Hide resolved
| int res; | ||
|
|
||
| if ((res = archive_read_open(inputArchive, &data, ok_cb, read_cb, ok_cb))) { | ||
| if ((archive_read_open(inputArchive, &data, ok_cb, read_cb, ok_cb))) { |
Contributor
There was a problem hiding this comment.
Is double parentheses necessary?
Contributor
Author
There was a problem hiding this comment.
I think it's not, removed them in e6aea67
8 tasks
martinzink
approved these changes
Jun 1, 2022
fgerlits
reviewed
Jun 1, 2022
fgerlits
approved these changes
Jun 1, 2022
szaszm
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile project with clang-14 generating compile_commands.json and use it to analyze code with clang-tidy-14. Clang-tidy is run on every cpp file modified in the pull request. Only an initial batch of checks is implemented, other checks should be implemented as part of MINIFICPP-1833 or other further tickets.
https://issues.apache.org/jira/browse/MINIFICPP-1832
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.