Skip to content

MINIFICPP-1500 Fix multiple archive tests running in parallel#1410

Closed
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-1500
Closed

MINIFICPP-1500 Fix multiple archive tests running in parallel#1410
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-1500

Conversation

@lordgamez
Copy link
Contributor

The NonRepeatingStringGenerator only generated an initial prefix from the current timestamp's millisecond count. Because of this if multiple ArchiveTests (FocusArchiveTests and ManipulateArchiveTests) were run in parallel it could occur, that they generated the same temp filename due to the same timestamp. This caused failures as the different test suites manipulated each other's test files.

https://issues.apache.org/jira/browse/MINIFICPP-1500


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@fgerlits fgerlits closed this in f1583c7 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants