MINIFICPP-1979 Use Coroutines with asio#1457
Closed
martinzink wants to merge 18 commits intoapache:mainfrom
Closed
MINIFICPP-1979 Use Coroutines with asio#1457martinzink wants to merge 18 commits intoapache:mainfrom
martinzink wants to merge 18 commits intoapache:mainfrom
Conversation
martinzink
changed the title
martinzink
force-pushed
the
utils_net_server_coro
branch
4 times, most recently
from
f91c3f8 to
32d6d9a
Compare
martinzink
force-pushed
the
utils_net_server_coro
branch
from
32d6d9a to
9d30a15
Compare
martinzink
force-pushed
the
utils_net_server_coro
branch
2 times, most recently
from
14d161c to
2e0a64c
Compare
szaszm
reviewed
Jan 5, 2023
martinzink
force-pushed
the
utils_net_server_coro
branch
from
2e0a64c to
fb2cba6
Compare
adamdebreceni
approved these changes
Jan 11, 2023
szaszm
reviewed
Jan 11, 2023
fgerlits
reviewed
Jan 16, 2023
extensions/standard-processors/processors/NetworkListenerProcessor.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/tests/unit/ListenSyslogTests.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/tests/unit/ListenSyslogTests.cpp
Outdated
Show resolved
Hide resolved
martinzink
force-pushed
the
utils_net_server_coro
branch
from
a76b49d to
f37cffb
Compare
szaszm
reviewed
Jan 24, 2023
fgerlits
approved these changes
Jan 24, 2023
szaszm
reviewed
Jan 25, 2023
removed code duplication (CHECK_NO_ERROR, scheduleProcessorOnRandomPort) check for read errors in PutTCP removed stale comment from PutTCPTests.cpp
Co-authored-by: Marton Szasz <szaszm@apache.org>
martinzink
force-pushed
the
utils_net_server_coro
branch
from
0e86eb9 to
d6b898d
Compare
szaszm
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINIFICPP-1985 Run asio related tests on random ports
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.