MINIFICPP-2039 Dust off minificontroller#1503
Closed
lordgamez wants to merge 9 commits intoapache:mainfrom
Closed
Conversation
lordgamez
force-pushed
the
MINIFICPP-2039
branch
from
bb7baf9 to
068aa06
Compare
adamdebreceni
approved these changes
Feb 15, 2023
lordgamez
force-pushed
the
MINIFICPP-2039
branch
from
2a82c34 to
e22b4c4
Compare
lordgamez
force-pushed
the
MINIFICPP-2039
branch
from
e22b4c4 to
15e3b5b
Compare
lordgamez
force-pushed
the
MINIFICPP-2039
branch
2 times, most recently
from
423a145 to
3105e0b
Compare
fgerlits
reviewed
Mar 24, 2023
lordgamez
force-pushed
the
MINIFICPP-2039
branch
2 times, most recently
from
776b783 to
74a1870
Compare
fgerlits
approved these changes
Mar 29, 2023
szaszm
reviewed
Apr 6, 2023
szaszm
reviewed
Apr 13, 2023
lordgamez
force-pushed
the
MINIFICPP-2039
branch
from
8735105 to
03f64d3
Compare
szaszm
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2039
Depends on #1497
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.