Skip to content

MINIFICPP-263: Move merge content to an extension. Also remove circul…#153

Closed
phrocker wants to merge 2 commits intoapache:masterfrom
phrocker:MINIFICPP-263
Closed

MINIFICPP-263: Move merge content to an extension. Also remove circul…#153
phrocker wants to merge 2 commits intoapache:masterfrom
phrocker:MINIFICPP-263

Conversation

@phrocker
Copy link
Contributor

…ar dependencies

MINIFICPP-263: Remove boost deps by updating yaml-cpp

MINIFICPP-263: Resolve issues on u14

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…ar dependencies

MINIFICPP-263: Remove boost deps by updating yaml-cpp

MINIFICPP-263: Resolve issues on u14
@apiri
Copy link
Member

apiri commented Oct 25, 2017

reviewing

Copy link
Member

@apiri apiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked build and functionality in a few different environments and everything looked good. Verified lack of dependency on boost for running.

The upgrading of YAML CPP re-introduced all of its tests and additional sources (primarily Google Test) which were previously removed from the code base. Could we get those items/tests removed in this update as well?

@@ -0,0 +1,40 @@
set(gtest_force_shared_crt ${MSVC_SHARED_RT} CACHE BOOL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we kill the test folder. We had done this previously and will help keep our LICENSE a little tidier.

@phrocker
Copy link
Contributor Author

@apiri I removed the tests in my last commit.

@apiri
Copy link
Member

apiri commented Oct 26, 2017

Looks great. Will get this merged. Thanks!

@apiri
Copy link
Member

apiri commented Oct 26, 2017

@phrocker Included the closes phrase in the commit but didn't seem to get picked up here. If you could please close this when you get the opportunity it would be appreciated.

@asfgit asfgit closed this in 1d6b241 Oct 26, 2017
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
…ar dependencies

MINIFICPP-263: Remove boost deps by updating yaml-cpp

MINIFICPP-263: Resolve issues on u14

This closes apache#153.

Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants