MINIFICPP-263: Move merge content to an extension. Also remove circul…#153
MINIFICPP-263: Move merge content to an extension. Also remove circul…#153phrocker wants to merge 2 commits intoapache:masterfrom
Conversation
…ar dependencies MINIFICPP-263: Remove boost deps by updating yaml-cpp MINIFICPP-263: Resolve issues on u14
|
reviewing |
apiri
left a comment
There was a problem hiding this comment.
Checked build and functionality in a few different environments and everything looked good. Verified lack of dependency on boost for running.
The upgrading of YAML CPP re-introduced all of its tests and additional sources (primarily Google Test) which were previously removed from the code base. Could we get those items/tests removed in this update as well?
| @@ -0,0 +1,40 @@ | |||
| set(gtest_force_shared_crt ${MSVC_SHARED_RT} CACHE BOOL | |||
There was a problem hiding this comment.
Can we kill the test folder. We had done this previously and will help keep our LICENSE a little tidier.
|
@apiri I removed the tests in my last commit. |
|
Looks great. Will get this merged. Thanks! |
|
@phrocker Included the closes phrase in the commit but didn't seem to get picked up here. If you could please close this when you get the opportunity it would be appreciated. |
…ar dependencies MINIFICPP-263: Remove boost deps by updating yaml-cpp MINIFICPP-263: Resolve issues on u14 This closes apache#153. Signed-off-by: Aldrin Piri <aldrin@apache.org>
…ar dependencies
MINIFICPP-263: Remove boost deps by updating yaml-cpp
MINIFICPP-263: Resolve issues on u14
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.