MINIFICPP-1755 - Use std::span instead of gsl::span#1584
Closed
adamdebreceni wants to merge 11 commits intoapache:mainfrom
Closed
MINIFICPP-1755 - Use std::span instead of gsl::span#1584adamdebreceni wants to merge 11 commits intoapache:mainfrom
adamdebreceni wants to merge 11 commits intoapache:mainfrom
Conversation
fgerlits
reviewed
Jun 7, 2023
szaszm
reviewed
Jun 7, 2023
fgerlits
approved these changes
Jun 9, 2023
szaszm
reviewed
Jun 14, 2023
martinzink
approved these changes
Jun 21, 2023
szaszm
reviewed
Jun 29, 2023
lordgamez
approved these changes
Jul 4, 2023
Contributor
lordgamez
left a comment
lordgamez
left a comment
There was a problem hiding this comment.
LGTM, just a really minor suggestion
Comment on lines
18
to
19
| #ifndef LIBMINIFI_INCLUDE_CORE_REPOSITORY_ATOMICREPOENTRIES_H_ | ||
| #define LIBMINIFI_INCLUDE_CORE_REPOSITORY_ATOMICREPOENTRIES_H_ |
Contributor
There was a problem hiding this comment.
Could replace this with #pragma once
szaszm
approved these changes
Jul 6, 2023
fgerlits
pushed a commit
to fgerlits/nifi-minifi-cpp
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Ferenc Gerlits <fgerlits@gmail.com> This closes apache#1584
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.