MINIFICPP-273 Simplify configuration of MiNiFi - C++ by allowing defa…#162
MINIFICPP-273 Simplify configuration of MiNiFi - C++ by allowing defa…#162ai-christianson wants to merge 1 commit intoapache:masterfrom
Conversation
| infoMessage += defaultValue.as<std::string>(); | ||
| } | ||
| logger_->log_info(infoMessage.c_str()); | ||
| result = defaultValue; |
There was a problem hiding this comment.
no return of the result. please run make linter
There was a problem hiding this comment.
My bad. Will fix & re-push.
I didn't notice any issues in make linter, though.
ai-christianson
force-pushed
the
MINIFICPP-273
branch
from
a4f27dd to
8359ebc
Compare
|
Fixed review issues. Ready for more review/merge. |
| procCfg.schedulingStrategy = procNode["scheduling strategy"].as<std::string>(); | ||
| auto strategyNode = getOptionalField(&procNode, | ||
| "scheduling strategy", | ||
| YAML::Node("EVENT_DRIVEN"), |
There was a problem hiding this comment.
We should move this elsewhere.
There was a problem hiding this comment.
Move the Yaml::Node(...), or the getOptionalField call? And where to?
There was a problem hiding this comment.
Sorry I meant the YAML::Node. I shouldn't have been so terse.
Here is a better way of putting it: Could we make it so that we centralized the defaults in one place so in case of change it's easier to track down? I know this isn't really the guise of the PR; however, it may improve the hygiene of this class to do so or make a follow on ticket.
In regards to where...perhaps some place in the class? A mapping or just static values for the fields? I don't know, I'm open to anything.
…ult values for scheduling strategy and period.
ai-christianson
force-pushed
the
MINIFICPP-273
branch
from
8359ebc to
1096b4c
Compare
|
Ready for another look. |
phrocker
left a comment
phrocker
left a comment
There was a problem hiding this comment.
+1 thanks @achristianson
…ult values for scheduling strategy and period. This closes apache#162. Signed-off-by: Marc Parisi <phrocker@apache.org>
3 participants
…ult values for scheduling strategy and period.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.