Skip to content

MINIFICPP-276: Add EXCLUDE_BOOST option#166

Closed
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFICPP-276
Closed

MINIFICPP-276: Add EXCLUDE_BOOST option#166
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFICPP-276

Conversation

@phrocker
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ai-christianson
Copy link
Contributor

LGTM, however I suspect any boost at all may be more trouble than it's worth, given our current minimal coupling with it.

I would be open to keeping boost for future extensions if there is a compelling case for it, and then sequestering it to extensions which are implicitly disabled if EXCLUDE_BOOST is set.

@asfgit asfgit closed this in adbed83 Oct 31, 2017
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
Signed-off-by: Bin Qiu <benqiu2016@gmail.com>

This closes apache#166.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants