Skip to content

MINIFI-218: GetGPS processor implementation#172

Closed
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFI-218
Closed

MINIFI-218: GetGPS processor implementation#172
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFI-218

Conversation

@phrocker
Copy link
Contributor

@phrocker phrocker commented Nov 3, 2017

GetGPS refactoring

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@phrocker phrocker changed the title MINIFI-218: Update per current MiNiFi C++ standards MINIFI-218: GetGPS processor implementation Nov 3, 2017
@minifirocks
Copy link

@phrocker looks good, please merge the two commits into one.

…i C++ standards

GetGPS refactoring

MINIFI-218: Fix GPS Test linter error
@asfgit asfgit closed this in f09ad61 Nov 11, 2017
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
…i C++ standards

GetGPS refactoring

MINIFI-218: Fix GPS Test linter error

This closes apache#172.

Signed-off-by: Bin Qiu <benqiu2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants