Skip to content

MINIFICPP-2318 Use libc++ in the clang CI build#1746

Closed
fgerlits wants to merge 2 commits intoapache:mainfrom
fgerlits:MINIFICPP-2318_Use-libc++-in-the-clang-CI-build
Closed

MINIFICPP-2318 Use libc++ in the clang CI build#1746
fgerlits wants to merge 2 commits intoapache:mainfrom
fgerlits:MINIFICPP-2318_Use-libc++-in-the-clang-CI-build

Conversation

@fgerlits
Copy link
Contributor

We used to use libc++ as the standard library in the ubuntu_22_04_clang CI build, but this got accidentally lost in some recent change, and now we build with libstdc++.

This change reverts to using libc++.

https://issues.apache.org/jira/browse/MINIFICPP-2318


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@fgerlits fgerlits marked this pull request as draft March 20, 2024 14:05
Non-cmake dependencies, eg. Pcap, can't use the CMake flags (at least without
a custom patch), but they work fine with these environment variables.
@fgerlits fgerlits force-pushed the MINIFICPP-2318_Use-libc++-in-the-clang-CI-build branch from 33a3540 to 6aff77b Compare March 20, 2024 16:00
@szaszm
Copy link
Member

szaszm commented Mar 20, 2024

The ubuntu issue is because "ppa.launchpad.net" is down, so we can't install newer compiler versions. https://status.canonical.com/

@fgerlits fgerlits marked this pull request as ready for review March 20, 2024 16:23
@fgerlits fgerlits requested review from martinzink and szaszm March 20, 2024 16:23
Copy link
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remember this limitation about cmake vs envvar settings while reviewing last time, but thanks for catching and fixing it.

@szaszm szaszm closed this in ba29f47 Mar 21, 2024
@fgerlits fgerlits deleted the MINIFICPP-2318_Use-libc++-in-the-clang-CI-build branch April 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants