Skip to content

MINIFICPP-2429 Remove onTriggerSharedPtr/onScheduleSharedPtr#1843

Closed
martinzink wants to merge 2 commits intoapache:mainfrom
martinzink:MINIFICPP-2429_and_2430
Closed

MINIFICPP-2429 Remove onTriggerSharedPtr/onScheduleSharedPtr#1843
martinzink wants to merge 2 commits intoapache:mainfrom
martinzink:MINIFICPP-2429_and_2430

Conversation

@martinzink
Copy link
Member

MINIFICPP-2430 Remove CollectorInitiatedSubscription

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink force-pushed the MINIFICPP-2429_and_2430 branch 2 times, most recently from 2dc5065 to 4e6b71b Compare July 22, 2024 12:54
@martinzink martinzink marked this pull request as ready for review July 22, 2024 14:51
@martinzink martinzink force-pushed the MINIFICPP-2429_and_2430 branch from 4e6b71b to 434975b Compare July 24, 2024 08:53
@szaszm szaszm force-pushed the MINIFICPP-2429_and_2430 branch from 434975b to f9e7c46 Compare August 13, 2024 22:29
@szaszm
Copy link
Member

szaszm commented Aug 13, 2024

rebased to main

@szaszm szaszm closed this in 2d3a41b Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants