Skip to content

MINIFICPP-2819 Fix LibSSH2 link failure on Windows#2180

Open
lordgamez wants to merge 1 commit into
apache:mainfrom
lordgamez:MINIFICPP-2819
Open

MINIFICPP-2819 Fix LibSSH2 link failure on Windows#2180
lordgamez wants to merge 1 commit into
apache:mainfrom
lordgamez:MINIFICPP-2819

Conversation

@lordgamez
Copy link
Copy Markdown
Contributor

@lordgamez lordgamez commented May 19, 2026

This change fixes the compilation issues of SFTP extension and tests, but SFTP test server is still not implemented on Windows so tests are still disabled on Windows for the time being, a new ticket is opened for fixing the tests: https://issues.apache.org/jira/browse/MINIFICPP-2820

https://issues.apache.org/jira/browse/MINIFICPP-2819


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread thirdparty/libssh2/fix-windows-ioctl.patch
@szaszm szaszm requested a review from Copilot May 19, 2026 14:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants