MINIFI-139 - Resolved OS X 10.12 build failures by introducing Cmake#26
Closed
jdye64 wants to merge 3 commits intoapache:masterfrom
jdye64:MINIFI-139
Closed
MINIFI-139 - Resolved OS X 10.12 build failures by introducing Cmake#26jdye64 wants to merge 3 commits intoapache:masterfrom jdye64:MINIFI-139
jdye64 wants to merge 3 commits intoapache:masterfrom
jdye64:MINIFI-139
Conversation
find modules for LevelDB and UUID for both includes and libraries.
Member
|
reviewing |
Member
|
hey @jdye64 things look overall and would like to avoid the absolute path. could you let me know the version of XCode you have in your OS X environment? |
find_package(Boost REQUIRED) approach
Member
|
@jdye64 changes look good and the find package seems like the best path forward. will merge this in and thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find modules for LevelDB and UUID for both includes and libraries.