MINIFICPP-465 Implemented regex validation of properties#350
Closed
ai-christianson wants to merge 1 commit intoapache:masterfrom
Closed
MINIFICPP-465 Implemented regex validation of properties#350ai-christianson wants to merge 1 commit intoapache:masterfrom
ai-christianson wants to merge 1 commit intoapache:masterfrom
Conversation
ai-christianson
changed the title
ai-christianson
changed the title
phrocker
reviewed
May 31, 2018
| #include <memory> | ||
| #include <vector> | ||
| #include <set> | ||
| #include <regex> |
Contributor
There was a problem hiding this comment.
Not all versions of the compiler support regex. You'll need to handle the C and C++ paths. I think GetFile is an example.
phrocker
reviewed
May 31, 2018
| } | ||
| logging::LOG_ERROR(logger_) << err_msg; | ||
| if (prop_pair.second.getValue().empty()) { | ||
| std::string reason("required property '"); |
Contributor
There was a problem hiding this comment.
Why not use a string stream here?
phrocker
reviewed
May 31, 2018
| void YamlConfiguration::raiseComponentError(const std::string &component_name, | ||
| const std::string &yaml_section, | ||
| const std::string &reason) const { | ||
| std::string err_msg = "Unable to parse configuration file for component named '"; |
Contributor
There was a problem hiding this comment.
A string stream or the like may make this more readable.
phrocker
reviewed
May 31, 2018
| REQUIRE(!rootFlowConfig->findProcessor("XYZ")->getUUIDStr().empty()); | ||
| } | ||
|
|
||
| class DummyComponent : public core::ConfigurableComponent { |
Contributor
There was a problem hiding this comment.
let's leave override out of libminifi/ and keep it in extensions due to compiler versioning.
phrocker
reviewed
May 31, 2018
| if (!prop_regex_str.empty()) { | ||
| std::regex prop_regex(prop_regex_str); | ||
| if (!std::regex_match(prop_pair.second.getValue(), prop_regex)) { | ||
| std::string reason("property '"); |
Contributor
There was a problem hiding this comment.
Same comment RE the readability. Stringstream may help with making this easier to read.
ai-christianson
force-pushed
the
MINIFICPP-465
branch
2 times, most recently
from
e354d27 to
150e112
Compare
ai-christianson
force-pushed
the
MINIFICPP-465
branch
from
150e112 to
977127b
Compare
Contributor
Author
|
Fixed. |
Contributor
Author
|
Build fails are timeouts after 52/53 passed unit tests; suspect possible travis environmental issue. |
ai-christianson
force-pushed
the
MINIFICPP-465
branch
from
977127b to
7bf3a32
Compare
Contributor
Author
|
Rebased & all issues addressed. Ready for review. |
phrocker
approved these changes
Jul 31, 2018
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#350. Signed-off-by: Marc Parisi <phrocker@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.