Skip to content

MINIFICPP-561 Added internal/static build of bzip2#375

Closed
ai-christianson wants to merge 1 commit intoapache:masterfrom
ai-christianson:MINIFICPP-561
Closed

MINIFICPP-561 Added internal/static build of bzip2#375
ai-christianson wants to merge 1 commit intoapache:masterfrom
ai-christianson:MINIFICPP-561

Conversation

@ai-christianson
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@phrocker
Copy link
Contributor

Would you be able to move this to a separate submodule. The combination of these is making CMAKE a bit difficult to read.

@ai-christianson
Copy link
Contributor Author

@phrocker I agree. Since this would affect all the external project builds, I created MINIFICPP-570 to move all external builds out to their own space(s) consistently.

@asfgit asfgit closed this in b57af84 Jul 24, 2018
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
This closes apache#375.

Signed-off-by: Marc Parisi <phrocker@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants