Skip to content

MINIFICPP-573: Remove lower level build information that is unnecessary#381

Closed
phrocker wants to merge 2 commits intoapache:masterfrom
phrocker:MINIFICPP-573-POTATO
Closed

MINIFICPP-573: Remove lower level build information that is unnecessary#381
phrocker wants to merge 2 commits intoapache:masterfrom
phrocker:MINIFICPP-573-POTATO

Conversation

@phrocker
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@ai-christianson ai-christianson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the unit test? A bit concerned that a change this big did not break any existing tests (which suggests that there is no coverage of this code).

@phrocker
Copy link
Contributor Author

phrocker commented Jul 25, 2018

@achristianson Ah those pieces were recently added with the intention that they may be removed.. Tests exist ( within a SIT environment, I believe ) in a docker container, which is not part of this build. As a result their removal has no unit tests.

@apiri
Copy link
Member

apiri commented Aug 7, 2018

looks like we have a test failure:

-------------------------------------------------------------------------------
Test Valid Regex
-------------------------------------------------------------------------------
/home/apiri/development/code/nifi-minifi-cpp/libminifi/test/unit/PropertyValidationAgentInfoTests.cpp:47
...............................................................................

/home/apiri/development/code/nifi-minifi-cpp/libminifi/test/unit/PropertyValidationAgentInfoTests.cpp:52: FAILED:
  REQUIRE( resp.children.size() > 0 )
with expansion:
  0 > 0

@phrocker phrocker force-pushed the MINIFICPP-573-POTATO branch from 08c3821 to 0b6613e Compare August 7, 2018 15:21
@asfgit asfgit closed this in e02304b Aug 7, 2018
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
MINIFICPP-576: Roll system components into bundle. Update tests for these components

This closes apache#381.

Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants