Skip to content

MINIFICPP-584 - update pybind to prevent hang for Python3.7 on OSX#385

Closed
dtrodrigues wants to merge 1 commit intoapache:masterfrom
dtrodrigues:MINIFICPP-584
Closed

MINIFICPP-584 - update pybind to prevent hang for Python3.7 on OSX#385
dtrodrigues wants to merge 1 commit intoapache:masterfrom
dtrodrigues:MINIFICPP-584

Conversation

@dtrodrigues
Copy link
Contributor

@dtrodrigues dtrodrigues commented Aug 1, 2018

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@phrocker phrocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! Will merge in a a bit

@asfgit asfgit closed this in 1a3136b Aug 1, 2018
dtrodrigues added a commit to dtrodrigues/nifi-minifi-cpp that referenced this pull request Aug 1, 2018
This closes apache#385.

Signed-off-by: Marc Parisi <phrocker@apache.org>
dtrodrigues added a commit to dtrodrigues/nifi-minifi-cpp that referenced this pull request Aug 1, 2018
This closes apache#385.

Signed-off-by: Marc Parisi <phrocker@apache.org>
@dtrodrigues dtrodrigues deleted the MINIFICPP-584 branch August 3, 2018 00:26
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
This closes apache#385.

Signed-off-by: Marc Parisi <phrocker@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants