Skip to content

MINIFICPP-583: Allow Expression language to compile if CURL is disabl…#387

Closed
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFICPP-583
Closed

MINIFICPP-583: Allow Expression language to compile if CURL is disabl…#387
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFICPP-583

Conversation

@phrocker
Copy link
Contributor

@phrocker phrocker commented Aug 3, 2018

…ed while also honoring the request to disable CURL functionality

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…ed while also honoring the request to disable CURL functionality
@apiri
Copy link
Member

apiri commented Aug 3, 2018

reviewing

@apiri
Copy link
Member

apiri commented Aug 3, 2018

code changes look good. was able to verify the issue before PR and then its resolution with the patch applied. will get this merged. thanks!

@asfgit asfgit closed this in 82557de Aug 3, 2018
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
…ed while also honoring the request to disable CURL functionality

This closes apache#387.
This closes apache#380.

Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants