MINIFICPP-623: Add trace capabilities to controller and agent#424
MINIFICPP-623: Add trace capabilities to controller and agent#424phrocker wants to merge 2 commits intoapache:masterfrom
Conversation
|
reviewing |
|
Haven't really dug in, but I did see that Travis is reporting that the C2Jstack test is failing. Seems like it might be environmental for Travis but haven't inspected too much. |
|
@apiri yeah it seems that it's because they are run in parallel and there is a port collision. I am changing port numbers in the tests. |
|
great, thanks! |
phrocker
force-pushed
the
MINIFICPP-623
branch
5 times, most recently
from
018beaf to
90ee6fa
Compare
MINIFICPP-623: Change test port and controller sizes for OSX MINIFICPP-623: avoid ifdef checks that may or may not exist on platforms -- use cmake check
phrocker
force-pushed
the
MINIFICPP-623
branch
from
90ee6fa to
9abdede
Compare
|
I tried adding commits but GH is not correctly tracking my branch for some reason. Travis and Appveyor have passed and I added an empty commit and updates to the readme to no avail. May have to open another. |
apiri
left a comment
apiri
left a comment
There was a problem hiding this comment.
very slick. build and tests all pass. I noted a few stylistic things in docs that I will take care of on merge. Otherwise code looks fine and the functionality works great.
| # Apache NiFi - MiNiFi - Operations Readme. | ||
|
|
||
|
|
||
| This readme defines operational commands for managaging instances. |
|
|
||
| ## Description | ||
|
|
||
| Apache NiFi MiNiFI C++ can can be managed through our [C2 protocol](https://cwiki.apache.org/confluence/display/MINIFI/C2+Design+Proposal) |
There was a problem hiding this comment.
- minifi styling
- save the can can for dancing
|
|
||
| $ controller.socket.host=localhost | ||
| $ controller.socket.port=9998 | ||
| $ controller.socket.local.any.interface=true/false ( default false) |
| #### Update flow | ||
| ./minificontroller --updateflow "config yml" | ||
|
|
||
| *Updates the flow file reference and performs a warm re-deploy. |
There was a problem hiding this comment.
missing space is causing everything following to get italicized
| #### Get full connection command | ||
| ./minificontroller --getfull | ||
|
|
||
| *Provides a list of full connections, if any. |
There was a problem hiding this comment.
missing space is causing everything following to get italicized
MINIFICPP-623: Change test port and controller sizes for OSX MINIFICPP-623: avoid ifdef checks that may or may not exist on platforms -- use cmake check This closes apache#424. Signed-off-by: Aldrin Piri <aldrin@apache.org>
2 participants
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.