Skip to content

MINIFICPP-654 - C API: failure callback improvements#429

Closed
arpadboda wants to merge 1 commit intoapache:masterfrom
arpadboda:MINIFICPP-654
Closed

MINIFICPP-654 - C API: failure callback improvements#429
arpadboda wants to merge 1 commit intoapache:masterfrom
arpadboda:MINIFICPP-654

Conversation

@arpadboda
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@arpadboda
Copy link
Contributor Author

It's not final, further changes expected as I'm not yet satisfied with the code quality, but the concept can be reviewed at least.

@phrocker
Copy link
Contributor

@arpadboda is this ready for review? You stated, "it's not final"

@arpadboda
Copy link
Contributor Author

Yes, I plan some further changes, but most probably in scope of a different PR.

#include "capi/cstructs.h"
#include "capi/api.h"

enum FailureStrategy { AS_IS, ROLLBACK };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think AS_IS could be clarified in the scope of the enumeration to better indicate the intent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that it's not the best naming as doesn't properly describe what happens, but no better idea. @apiri - you are our last hope. :)

@phrocker
Copy link
Contributor

phrocker commented Oct 29, 2018

Looks good. minor comments, nothing that's a big deal...might want to resolve the misspelling, though.

@asfgit asfgit closed this in 2fb4021 Oct 30, 2018
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
This closes apache#429.

Signed-off-by: Marc Parisi <phrocker@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants