MINIFICPP-654 - C API: failure callback improvements#429
Closed
arpadboda wants to merge 1 commit intoapache:masterfrom
Closed
MINIFICPP-654 - C API: failure callback improvements#429arpadboda wants to merge 1 commit intoapache:masterfrom
arpadboda wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
It's not final, further changes expected as I'm not yet satisfied with the code quality, but the concept can be reviewed at least. |
Contributor
|
@arpadboda is this ready for review? You stated, "it's not final" |
Contributor
Author
|
Yes, I plan some further changes, but most probably in scope of a different PR. |
phrocker
reviewed
Oct 29, 2018
libminifi/include/capi/Plan.h
Outdated
| #include "capi/cstructs.h" | ||
| #include "capi/api.h" | ||
|
|
||
| enum FailureStrategy { AS_IS, ROLLBACK }; |
Contributor
There was a problem hiding this comment.
Do you think AS_IS could be clarified in the scope of the enumeration to better indicate the intent?
Contributor
Author
There was a problem hiding this comment.
I agree with you that it's not the best naming as doesn't properly describe what happens, but no better idea. @apiri - you are our last hope. :)
Contributor
|
Looks good. minor comments, nothing that's a big deal...might want to resolve the misspelling, though. |
e229d2a to
b4007ba
Compare
b4007ba to
f7060a2
Compare
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#429. Signed-off-by: Marc Parisi <phrocker@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.