MINIFICPP-665: Add reference checks for self#435
Closed
phrocker wants to merge 2 commits intoapache:masterfrom
Closed
MINIFICPP-665: Add reference checks for self#435phrocker wants to merge 2 commits intoapache:masterfrom
phrocker wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
The implementation is fine, I wonder if: |
Contributor
Author
|
@arpadboda yah we can compare pointers with t metaprogramming. But we lose the ability to change source of streams. Was on fence about that. Still am.. |
phrocker
force-pushed
the
MINIFICPP-665
branch
from
6bf85fd to
a22d786
Compare
arpadboda
approved these changes
Nov 14, 2018
libminifi/src/io/BaseStream.cpp
Outdated
| */ | ||
| int BaseStream::readData(uint8_t *buf, int buflen) { | ||
| return Serializable::read(buf, buflen, reinterpret_cast<DataStream*>(composable_stream_)); | ||
| if (composable_stream_ == this) { |
phrocker
force-pushed
the
MINIFICPP-665
branch
from
a22d786 to
df7787d
Compare
phrocker
force-pushed
the
MINIFICPP-665
branch
2 times, most recently
from
ebfe01a to
b6f15fa
Compare
phrocker
force-pushed
the
MINIFICPP-665
branch
from
0924a8f to
0945437
Compare
arpadboda
approved these changes
Nov 14, 2018
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
MINIFICPP-665: Fix tests after rebase This closes apache#435. Approved by arpadboda on GH. Signed-off-by: Marc Parisi <phrocker@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.