MINIFICPP-695 - NanoFi Examples appear to be broken#462
Closed
arpadboda wants to merge 1 commit intoapache:masterfrom
Closed
MINIFICPP-695 - NanoFi Examples appear to be broken#462arpadboda wants to merge 1 commit intoapache:masterfrom
arpadboda wants to merge 1 commit intoapache:masterfrom
Conversation
arpadboda
force-pushed
the
MINIFICPP-695
branch
from
a868e0b to
c21fb91
Compare
arpadboda
commented
Dec 18, 2018
| * @return 0 in case of success, -1 otherwise (already existed) | ||
| **/ | ||
| uint8_t add_attribute(flow_file_record*, const char *key, void *value, size_t size); | ||
| int8_t add_attribute(flow_file_record*, const char *key, void *value, size_t size); |
Contributor
Author
There was a problem hiding this comment.
These didn't really match implementartion/documentation :)
| * @return 0 on success, -1 otherwise (doesn't exist) | ||
| **/ | ||
| uint8_t remove_attribute(flow_file_record*, char *key); | ||
| int8_t remove_attribute(flow_file_record*, const char * key); |
Contributor
Author
There was a problem hiding this comment.
This didn't even link as the impl in the cpp file was written for
const char * key
| return new_ff; | ||
| } | ||
|
|
||
| flow_file_record* create_ff_object_na(const char *file, const size_t len, const uint64_t size) { |
Contributor
Author
There was a problem hiding this comment.
This became the "construtor" to avoid duplication of member initializations.
arpadboda
force-pushed
the
MINIFICPP-695
branch
from
c21fb91 to
1cbeaf6
Compare
arpadboda
commented
Dec 18, 2018
Contributor
Author
There was a problem hiding this comment.
Important changes:
-Fixed transmit_flowfile example.
-Added API function to create flow file without content (attributes only)
-Fixed transmit API function to handle the lack of content or attributes properly
-Added some null checks to make the API more robust
-Added robustness tests
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#462. Signed-off-by: Marc Parisi <phrocker@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.