Minificpp 764: Add docker builds for different systems.#511
Minificpp 764: Add docker builds for different systems.#511phrocker wants to merge 4 commits intoapache:masterfrom
Conversation
apiri
left a comment
apiri
left a comment
There was a problem hiding this comment.
Still working through verifying but wanted to post some initial comments as I see you are working through things.
|
|
||
| ### Building For Other Distros | ||
| If you have docker installed on your machine you can build for CentOS 7, Fedoera 29, Ubuntu 16, Ubuntu 18, and Debian 9 via our make docker commands. The following table | ||
| provides the command to build your distro and the output file in your build directoiry. Since the versions are limited ( except for Ubuntu ) we output the archive based on the distros name. |
|
|
||
| # First stage: the build environment | ||
| # Edge required for rocksdb | ||
| FROM centos:latest AS builder |
There was a problem hiding this comment.
should we lock onto a specific version here? Or at least the major release?
|
|
||
| ### Building For Other Distros | ||
| If you have docker installed on your machine you can build for CentOS 7, Fedoera 29, Ubuntu 16, Ubuntu 18, and Debian 9 via our make docker commands. The following table | ||
| provides the command to build your distro and the output file in your build directoiry. Since the versions are limited ( except for Ubuntu ) we output the archive based on the distros name. |
apiri
left a comment
apiri
left a comment
There was a problem hiding this comment.
Changes look good here and would be fine with it merging as is. Let me know your preference on whether we should roll the Maven repo/volume approach into this effort or do a follow on issue/pr to address. I can take care of the readme fixes on merge.
|
@apiri My preference is to do that in a follow on. It's a really good idea, but I think building without JNI and with an attached repo can be a follow on. |
|
@phrocker Sounds good. Will take care of the typos and specifying 7 for CentOS on merge. Good bit of functionality! |
This closes apache#511. Signed-off-by: Aldrin Piri <aldrin@apache.org>
This closes apache#511. Signed-off-by: Aldrin Piri <aldrin@apache.org>
2 participants
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.