MINIFICPP-789: Minor updates to readme#523
Closed
phrocker wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
|
reviewing |
apiri
approved these changes
Mar 26, 2019
Member
apiri
left a comment
apiri
left a comment
There was a problem hiding this comment.
Changes look good. Noticed one minor issue for the name of the option in bootstrap. Will take care of this on merge.
| # Apache MiNiFi Extensions Guide | ||
|
|
||
| To enable all extensions for your platform, you may use -DENABLE_ALL=TRUE OR select option m in the bootstrap.sh guided build process defined in the [ReadMe](https://github.com/apache/nifi-minifi-cpp/#bootstrapping) | ||
| To enable all extensions for your platform, you may use -DENABLE_ALL=TRUE OR select the option for "Enabling all Extensions" in the bootstrap script. [ReadMe](https://github.com/apache/nifi-minifi-cpp/#bootstrapping) |
Contributor
Author
There was a problem hiding this comment.
ah, this was (sadly) intentional as "Enable all extensions" doesn't enable everything. It was meant to be "air quotes that imply something but not really..."
I was planning on adding more to this at a later time, so I think I will clarify that not all extensions can be enabled for all platforms instead of using the odd wording I chose. Thanks!
apiri
pushed a commit
to apiri/nifi-minifi-cpp
that referenced
this pull request
Mar 26, 2019
This closes apache#523. Signed-off-by: Aldrin Piri <aldrin@apache.org>
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#523. Approved on GH by @apiri. Signed-off-by: Marc Parisi <phrocker@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.