MINIFICPP-694 - Ensure that processor consist of proper phases#536
Closed
arpadboda wants to merge 1 commit intoapache:masterfrom
Closed
MINIFICPP-694 - Ensure that processor consist of proper phases#536arpadboda wants to merge 1 commit intoapache:masterfrom
arpadboda wants to merge 1 commit intoapache:masterfrom
Conversation
arpadboda
commented
Apr 16, 2019
| int add_custom_processor(const char * name, processor_logic* logic); | ||
| int var_add_custom_processor(custom_processor_args in); | ||
|
|
||
| #define add_custom_processor(...) var_add_custom_processor((custom_processor_args){__VA_ARGS__}); |
Contributor
Author
There was a problem hiding this comment.
I know it looks weird, although this way I could extend the C API with an optional argument, so this change doesn't break anything. (For eg. the hash_file example, that uses this call)
Moreover it supports funny signatures, like:
add_custom_processor("myproc2", .onsc_cb = custom_onschedule_logic);
Contributor
There was a problem hiding this comment.
is it not feasible to add those arguments to processor_logic?
Contributor
Author
There was a problem hiding this comment.
That was just typedef for a function pointer, so not really.
I have to admit that the first signature was not really future-proof, at least this one is definitely is.
arpadboda
force-pushed
the
MINIFICPP-694
branch
from
4245207 to
7fdca0c
Compare
phrocker
approved these changes
Apr 18, 2019
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#536. Signed-off-by: Marc Parisi <phrocker@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.