Skip to content

MINIFI-235: Resolve hostname ident#65

Closed
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFI-235-B
Closed

MINIFI-235: Resolve hostname ident#65
phrocker wants to merge 1 commit intoapache:masterfrom
phrocker:MINIFI-235-B

Conversation

@phrocker
Copy link
Contributor

@phrocker phrocker commented Mar 9, 2017

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@randerzander
Copy link
Contributor

Tested this in CentOS7 in docker, as well as from one physical host to another. All works as expected using shortnames and fqdns.

@phrocker
Copy link
Contributor Author

phrocker commented Mar 9, 2017

@randerzander big thanks for testing this for me!

@jdye64
Copy link
Contributor

jdye64 commented Mar 9, 2017

reviewing

@jdye64
Copy link
Contributor

jdye64 commented Mar 9, 2017

Tested using official MiNiFi Docker image against official NiFi Docker image running on Mac OS X host. Was able to successfully transfer flowfiles from minifi to nifi using fqdn where previously only ip address worked. Thanks @randerzander for pointing that out and @phrocker for the quick fix.

@asfgit asfgit closed this in 60f0212 Mar 9, 2017
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
This closes apache#65

Signed-off-by: Jeremy Dyer <jeremydyer@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants