Skip to content

MINIFICPP-916 - Turn off java build OpenCV#673

Closed
nghiaxlee wants to merge 1 commit intoapache:masterfrom
nghiaxlee:MINIFICPP-916
Closed

MINIFICPP-916 - Turn off java build OpenCV#673
nghiaxlee wants to merge 1 commit intoapache:masterfrom
nghiaxlee:MINIFICPP-916

Conversation

@nghiaxlee
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge.

@bakaid - just a heads-up, I think this is going to conflict with your 3rd party build changes,

@arpadboda arpadboda closed this in 35ff1d2 Nov 6, 2019
msharee9 pushed a commit to msharee9/nifi-minifi-cpp that referenced this pull request Nov 23, 2019
Signed-off-by: Arpad Boda <aboda@apache.org>

This closes apache#673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants