Closed
Conversation
arpadboda
reviewed
Feb 6, 2020
Contributor
arpadboda
left a comment
There was a problem hiding this comment.
Overall it's okay.
Added two comments to make sure the new logic is only triggered for "%%[0-9]+".
I think the treewalker should only be created once as a member of the processor.
As it only needs the dll and the logger, it can be created in init phase.
In this case it could store the unordered map and it doesn't need to be passed by the caller as a reference.
arpadboda
reviewed
Feb 6, 2020
bakaid
suggested changes
Feb 7, 2020
szaszm
approved these changes
Feb 10, 2020
bakaid
approved these changes
Feb 10, 2020
Contributor
bakaid
left a comment
There was a problem hiding this comment.
Tested by enabling "Audit Filtering Platform Connection" both for Success and Failure, and setting CWEL to listen on the Security channel.
It now resolves the "Layer Name" properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.