Skip to content

MINIFICPP-1147 Implemented.#728

Closed
am-c-p-p wants to merge 4 commits intoapache:masterfrom
am-c-p-p:minificpp-1147
Closed

MINIFICPP-1147 Implemented.#728
am-c-p-p wants to merge 4 commits intoapache:masterfrom
am-c-p-p:minificpp-1147

Conversation

@am-c-p-p
Copy link

@am-c-p-p am-c-p-p commented Feb 6, 2020

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@am-c-p-p am-c-p-p requested review from arpadboda and bakaid February 6, 2020 21:57
Copy link
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's okay.

Added two comments to make sure the new logic is only triggered for "%%[0-9]+".

I think the treewalker should only be created once as a member of the processor.
As it only needs the dll and the logger, it can be created in init phase.
In this case it could store the unordered map and it doesn't need to be passed by the caller as a reference.

Copy link
Contributor

@bakaid bakaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by enabling "Audit Filtering Platform Connection" both for Success and Failure, and setting CWEL to listen on the Security channel.
It now resolves the "Layer Name" properly.

Copy link
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpadboda arpadboda closed this in cf74e97 Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants