Merged
Conversation
szaszm
requested changes
Feb 24, 2020
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
Thanks for fixing these issues.
I think the issue below needs some attention, the rest of the changes look good.
| } | ||
| server_socket_ = std::make_shared<org::apache::nifi::minifi::io::TLSServerSocket>(socket_context, host, std::stoi(hostAndPort.at(1)), 3); | ||
| server_socket_->initialize(); | ||
| assert(0 == server_socket_->initialize()); |
Member
There was a problem hiding this comment.
This will leave server_socket_ uninitialized in release builds.
Contributor
Author
There was a problem hiding this comment.
No it will not.
All integration tests depend on assert, that's why they #undef NDEBUG before including assert.
Contributor
There was a problem hiding this comment.
@bakaid Huge Thanks for fixing this! I was scratching my head when CI for my PR was failing and then saw this. Big relief.
szaszm
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.