Skip to content

MINIFICPP-1190 fix build on clang 10#752

Closed
szaszm wants to merge 1 commit intoapache:masterfrom
szaszm:MINIFICPP-1190
Closed

MINIFICPP-1190 fix build on clang 10#752
szaszm wants to merge 1 commit intoapache:masterfrom
szaszm:MINIFICPP-1190

Conversation

@szaszm
Copy link
Copy Markdown
Member

@szaszm szaszm commented Apr 9, 2020

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown
Contributor

@bakaid bakaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good (well, no worse than the usual), also tested with clang-10, builds properly.

@bakaid bakaid closed this in 7a2b3aa Apr 14, 2020
@szaszm szaszm deleted the MINIFICPP-1190 branch April 14, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants