MINIFICPP-1208 - Enable rocksdb tools build

[bakaid]

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit?

For code changes:

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file?
• If applicable, have you updated the NOTICE file?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[szaszm]

This is a great idea, rocksdb tools will help a lot with debugging. However, I didn't see these binaries getting installed with make install. Is this intentional? Shouldn't we ship them with minifi c++?

[bakaid]

The binaries can be found in the thirdparty/rocksdb-install/bin/ directory in your build dir.
If by make install you mean make package, I think they should definitely not be included in our final distribution for two reasons:

• it is confusing to the users
• the binaries are quite large:

$ ls -lh thirdparty/rocksdb-install/bin/
total 30352
-rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:26 db_repl_stress
-rwxr-xr-x  1 danielbakai  staff   4.4M Apr 28 14:27 db_sanity_test
-rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:27 db_stress
-rwxr-xr-x  1 danielbakai  staff   5.2M Apr 28 14:27 ldb
-rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:27 rocksdb_dump
-rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:26 rocksdb_undump
-rwxr-xr-x  1 danielbakai  staff   5.2M Apr 28 14:27 sst_dump
-rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:27 write_stress```

[szaszm]

Makes sense, in this case I'm happy with the changes. Thanks. LGTM