MINIFICPP-1219 - PublishKafka should release connection when stopped#779
Closed
nghiaxlee wants to merge 2 commits into
Closed
MINIFICPP-1219 - PublishKafka should release connection when stopped#779nghiaxlee wants to merge 2 commits into
nghiaxlee wants to merge 2 commits into
Conversation
arpadboda
reviewed
May 13, 2020
Contributor
arpadboda
left a comment
There was a problem hiding this comment.
Mostly looks good, one minor comment.
arpadboda
approved these changes
May 13, 2020
szaszm
approved these changes
May 13, 2020
Member
szaszm
left a comment
There was a problem hiding this comment.
The code looks good. Tested minifi on Windows publishing to kafka on linux without TLS: successfully fixed the connection leak on flow reload.
+1
Member
|
On Travis, there was an error because the jobs couldn't download rocksdb. Could you trigger Travis again by pushing an empty change? (e.g. empty edit: changed my mind. Since all the errors are unrelated, I'm fine with merging right away. |
Contributor
Author
|
Thanks for testing and reviewing! We all agree that the errors are unrelated and I think merging will trigger travis anyway and . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.