MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support#784
Closed
hunyadi-dev wants to merge 10 commits intoapache:masterfrom
Closed
Conversation
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
2 times, most recently
from
f28eb0b to
0c507e6
Compare
8 tasks
szaszm
reviewed
May 22, 2020
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
Minor things, ideas, questions.
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
2 times, most recently
from
42e7338 to
990080a
Compare
arpadboda
reviewed
Jun 2, 2020
Contributor
arpadboda
left a comment
arpadboda
left a comment
There was a problem hiding this comment.
Nice tests!
Added some comments.
Generally wonder if script body and script path properties should be exclusive. In case both are provided, we should just throw in onschedule, that seems to be a misconfig case.
szaszm
reviewed
Jun 4, 2020
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
2 times, most recently
from
a67d47a to
bed4804
Compare
szaszm
reviewed
Jun 5, 2020
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
from
bed4804 to
7de3eb0
Compare
fgerlits
reviewed
Jun 5, 2020
fgerlits
reviewed
Jun 5, 2020
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
from
5fc4c92 to
1fefce5
Compare
szaszm
reviewed
Jun 9, 2020
szaszm
approved these changes
Jun 9, 2020
…ssor.cpp Co-authored-by: Szász Márton <szaszm@users.noreply.github.com>
…tUtils.h, clear redundant whitespace for docs
…() calls in ExecutePythonProcessor
…oDir(), restore header guard on TestUtils
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
from
1fefce5 to
2d87b51
Compare
…s test, use concatPath() in TestUtils.h
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
from
2d87b51 to
68b3f28
Compare
arpadboda
reviewed
Jun 18, 2020
Contributor
arpadboda
left a comment
arpadboda
left a comment
There was a problem hiding this comment.
Added some minor comments.
Overall nice work and nice tests!
… tests, reorder logic in ExecutePythonProcessor::loadPath() mitigate minor linter errors
hunyadi-dev
force-pushed
the
MINIFICPP-1206_inline_script_python_processor
branch
from
9cbe2fe to
4cbdbb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework and test ExecutePythonProcessor, add in-place script support
Some changes will be added in different PRs:
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.