MINIFICPP-1253 - Do not hang on full cycles#822
Closed
adamdebreceni wants to merge 4 commits into
Closed
Conversation
Contributor
|
@adamdebreceni some tests failed in CI: |
adamdebreceni
force-pushed
the
MINIFICPP-1253
branch
from
2752eff to
675e1ad
Compare
This was referenced Jul 6, 2020
adamdebreceni
force-pushed
the
MINIFICPP-1253
branch
from
675e1ad to
d4136a2
Compare
arpadboda
reviewed
Jul 7, 2020
Contributor
arpadboda
left a comment
arpadboda
left a comment
There was a problem hiding this comment.
Mostly looks good, added some minor comments.
arpadboda
reviewed
Jul 7, 2020
| didChange = true; | ||
| } | ||
| for (auto& reachedIt : dest->reachable_processors_) { | ||
| for (auto &reached_proc : reachedIt.second) { |
Contributor
There was a problem hiding this comment.
O(scary), but good enough in practice. :D
Contributor
Author
There was a problem hiding this comment.
I'm all for a O(better) solution 🙂 but yeah it probably won't be the bottleneck
arpadboda
approved these changes
Jul 7, 2020
Contributor
arpadboda
left a comment
arpadboda
left a comment
There was a problem hiding this comment.
LGTM, nice feature, thanks!
Will wait CI to complete before merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.