Skip to content

MINIFICPP-1299 Fix duplicate header guards#842

Closed
fgerlits wants to merge 3 commits intoapache:mainfrom
fgerlits:MINIFICPP-1299_Fix_duplicate_header_guards
Closed

MINIFICPP-1299 Fix duplicate header guards#842
fgerlits wants to merge 3 commits intoapache:mainfrom
fgerlits:MINIFICPP-1299_Fix_duplicate_header_guards

Conversation

@fgerlits
Copy link
Copy Markdown
Contributor

@fgerlits fgerlits commented Jul 20, 2020

  • Rename header guards to avoid duplicates
  • Rename the version of the CoapIntegrationBase class used in http tests to HTTPIntegrationBase
  • Delete the noop Expression class (it only had a constructor declaration without implementation)

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@fgerlits fgerlits changed the title Minificpp 1299 fix duplicate header guards MINIFICPP-1299 Fix duplicate header guards Jul 20, 2020
@fgerlits fgerlits marked this pull request as draft July 20, 2020 09:25
@fgerlits fgerlits marked this pull request as ready for review July 24, 2020 08:28
fgerlits added 3 commits July 24, 2020 10:42
Rename one of the versions of CoapIntegrationBase to
HTTPIntegrationBase.
This seems to be garbage left over from before the implementation of the real Expression class.
@fgerlits fgerlits force-pushed the MINIFICPP-1299_Fix_duplicate_header_guards branch from b840de1 to dcedda9 Compare July 24, 2020 09:21
Copy link
Copy Markdown
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thanks!

@arpadboda arpadboda closed this in 140f96c Jul 31, 2020
@fgerlits fgerlits deleted the MINIFICPP-1299_Fix_duplicate_header_guards branch May 31, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants