MINIFICPP-1288 - Remove unused stop() args, clean whitespaces and stop method in FlowController#856
Closed
hunyadi-dev wants to merge 4 commits intoapache:mainfrom
Closed
Conversation
szaszm
approved these changes
Jul 31, 2020
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
+1 but I recommend merging only after 0.8 was branched off.
…fault waiting time for FlowController::stop to zero
…ments and unused member fields
hunyadi-dev
force-pushed
the
MINIFICPP-1288_rework_flowcontroller_stop
branch
from
10db989 to
be219dd
Compare
fgerlits
approved these changes
Aug 5, 2020
arpadboda
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only change in logic in this PR should be that FlowControlProtocol now loses its default one second timeout. However, this method of communicating with minifi is not supported either way, so the change is fine.
This is part of several cleanup PRs for FlowController, before the implementation of configuration validation.