Skip to content

MINIFICPP-1309 - RAII based resourceClaim management#857

Closed
adamdebreceni wants to merge 7 commits intoapache:mainfrom
adamdebreceni:MINIFICPP-1309
Closed

MINIFICPP-1309 - RAII based resourceClaim management#857
adamdebreceni wants to merge 7 commits intoapache:mainfrom
adamdebreceni:MINIFICPP-1309

Conversation

@adamdebreceni
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@fgerlits
Copy link
Contributor

fgerlits commented Aug 6, 2020

Is the Windows (GitHub actions) test failure related to this change? It doesn't look like one of the usual flaky tests.

@adamdebreceni
Copy link
Contributor Author

Indeed I don't remember seeing RepoTests fail, although on my fork's CI run it did not fail

@szaszm
Copy link
Member

szaszm commented Aug 31, 2020

👀

Copy link
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@arpadboda arpadboda closed this in b4f2b5f Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants