MINIFICPP-1325 - Separate process group processor lookups for IDs and names, allow constructing ID-s from strings

[hunyadi-dev]

This is a cleanup PR before I start a refactor on configuration parsing, IDs and names lookups.

[szaszm]

For some reason I couldn't reply to the other review comments, so writing it here:
+1 for explicitly listing the captured variables, just for clarity, not safety.

[hunyadi-dev]

For some reason I couldn't reply to the other review comments, so writing it here:
+1 for explicitly listing the captured variables, just for clarity, not safety.

I would say listing the captured variables is just clutter-code in these cases. The lambdas mentioned capture everything in scope: there are no locals, this is captured and the single function args are also inputs for the lambda.

[adamdebreceni]

would constexpr allow us to make it an in-class initializer?

[hunyadi-dev]

I think it only works in c++17 or maybe even c++14.

[adamdebreceni]

you are right that from c++17 inline comes to the rescue, but even in c++11 we may (must) add an initializer to the declaration of a literal constexpr variable (and it is enough if it is not odr-used) (see here in section Constant static members)

#include <stdio.h>

struct A{
  static constexpr const char* FORMAT = "%d\n";
};

int main(){
  // uncommenting the following will generate a linker error
  // auto& ref = A::FORMAT;
  printf(A::FORMAT, 5);
}

it is not pivotal to move it to the header, I just wanted to share that it is possible

[szaszm]

Please make sure I can't reassign the string to something else. constexpr or top-level const achieves that.

[hunyadi-dev]

Made UUID_FORMAT_STRING constexpr.