Skip to content

MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation#871

Closed
hunyadi-dev wants to merge 1 commit intoapache:mainfrom
hunyadi-dev:MINIFICPP-1203_linter_remove_extra_space_around_parens
Closed

MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation#871
hunyadi-dev wants to merge 1 commit intoapache:mainfrom
hunyadi-dev:MINIFICPP-1203_linter_remove_extra_space_around_parens

Conversation

@hunyadi-dev
Copy link
Contributor

@hunyadi-dev hunyadi-dev commented Aug 13, 2020

Automatic fixes done using:

➜ make linter |& egrep -v '^Done processing|^Ignoring' |& tee errors.txt | less
➜ cat errors.txt | grep "Extra space before (" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ (/(/g" $1' sh
➜ cat errors.txt | grep "Extra space before )" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ )/)/g" $1' sh
➜ cat errors.txt | grep "Extra space after (" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/( /(/g" $1' sh
➜ cat errors.txt | grep "Extra space after )" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/) /)/g" $1' sh
➜ cat errors.txt | grep "Mismatching spaces" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/( /(/g" $1' sh
➜ cat errors.txt | grep "Mismatching spaces" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ )/)/g" $1' sh

ℹ️ A simple way to confirm that the changes affect white spaces only:

Screenshot 2020-08-13 at 9 24 35

…linter recommendation

Automatic replacements via:

make linter |& egrep -v '^Done processing|^Ignoring' |& tee errors.txt | less
cat errors.txt | grep "Extra space before (" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ (/(/g" $1' sh
cat errors.txt | grep "Extra space before )" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ )/)/g" $1' sh
cat errors.txt | grep "Extra space after (" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/( /(/g" $1' sh
cat errors.txt | grep "Extra space after )" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/) /)/g" $1' sh
cat errors.txt | grep "Mismatching spaces" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/( /(/g" $1' sh
cat errors.txt | grep "Mismatching spaces" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ )/)/g" $1' sh
@hunyadi-dev hunyadi-dev force-pushed the MINIFICPP-1203_linter_remove_extra_space_around_parens branch from 079dd1f to d06bd9a Compare August 13, 2020 13:54
@szaszm szaszm closed this in 4d218d9 Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants